Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[VarDumper] add force-collapse/expand + use it for traces#23967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
8ec15d0 to615d725CompareMemberAuthor
nicolas-grekas commentedAug 24, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
PR ready, screenshot updated, now with less visual debt :) |
615d725 to3a60277CompareContributor
Simperfit commentedAug 24, 2017
too much visual debt ! :p |
3a60277 to0e2d2b8Comparefabpot approved these changesAug 31, 2017
Member
fabpot commentedAug 31, 2017
Thank you@nicolas-grekas. |
fabpot added a commit that referenced this pull requestAug 31, 2017
…ces (nicolas-grekas)This PR was merged into the 3.4 branch.Discussion----------[VarDumper] add force-collapse/expand + use it for traces| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | not yet| Fixed tickets | -| License | MIT| Doc PR | -This improves dumping stack traces by expanding only frames that are outside of vendor dirs.Here the new CLI output (everything was expanded before):And here is the HTML output, with toggle-able frames:Todo:- [x] make tests pass :)Commits-------0e2d2b8 [VarDumper] add force-collapse/expand + use it for traces
fabpot added a commit that referenced this pull requestOct 29, 2017
…maxDepth (ogizanagi)This PR was merged into the 3.4 branch.Discussion----------[VarDumper] HtmlDumper: fix collapsing nodes with depth < maxDepth| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files -->| BC breaks? | no| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->| Tests pass? | yes (failures unrelated)| Fixed tickets | N/A <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR | N/AThis error happens since#23967:> (index):3 Uncaught TypeError: Cannot read property 'substr' of nullhttps://github.com/symfony/symfony/blob/98dae3edb1ba8fa35c06a8c9a459e0ffb9105826/src/Symfony/Component/VarDumper/Dumper/HtmlDumper.php#L325when trying to collapse the root node (or more precisely, the nodes with a depth <= maxDepth) because it misses one of the `sf-dump-expanded`/`sf-dump-compact` classes which are necessary for the toggling to work.Commits-------a1863c3 [VarDumper] HtmlDumper: fix collapsing nodes with depth <= maxDepth
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This improves dumping stack traces by expanding only frames that are outside of vendor dirs.
Here the new CLI output (everything was expanded before):
And here is the HTML output, with toggle-able frames:
Todo: