Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Console] Initialize lazily to render exceptions properly#23909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
d06cbbb to62174fdComparechalasr approved these changesAug 17, 2017
stof approved these changesAug 17, 2017
ogizanagi approved these changesAug 17, 2017
Member
chalasr commentedAug 17, 2017
Thank you@nicolas-grekas. |
chalasr added a commit that referenced this pull requestAug 17, 2017
…(nicolas-grekas)This PR was merged into the 2.7 branch.Discussion----------[Console] Initialize lazily to render exceptions properly| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -When an exception occurs in the constructor of an `Application`, exception handling is not yet set up.This typically happens when the container cannot be build for some reason, where calling `$this->add()` builds the container and fails.This PR makes initialization lazy so that it happens later on, when exception handling might be OK.Before:After:Commits-------62174fd [Console] Initialize lazily to render exceptions properly
This was referencedAug 28, 2017
Merged
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an exception occurs in the constructor of an
Application, exception handling is not yet set up.This typically happens when the container cannot be build for some reason, where calling
$this->add()builds the container and fails.This PR makes initialization lazy so that it happens later on, when exception handling might be OK.
Before:
After:
