Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Allow phpdocumentor/reflection-docblock 4#23897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
nicolas-grekas merged 1 commit intosymfony:3.3fromderrabus:3.3-allow-phpdoc-reflection-4Aug 16, 2017
Merged
Allow phpdocumentor/reflection-docblock 4#23897
nicolas-grekas merged 1 commit intosymfony:3.3fromderrabus:3.3-allow-phpdoc-reflection-4Aug 16, 2017
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
composer.json Outdated
| "symfony/polyfill-apcu":"~1.1", | ||
| "symfony/security-acl":"~2.8|~3.0", | ||
| "phpdocumentor/reflection-docblock":"^3.0", | ||
| "phpdocumentor/reflection-docblock":"^3.0 || ^4.0", |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
"^3.0|^4.0" for consistency (same below)
MemberAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Done.
cf549a6 to1a5fd79Comparenicolas-grekas approved these changesAug 15, 2017
xabbuh approved these changesAug 15, 2017
Member
nicolas-grekas commentedAug 16, 2017
Thank you@derrabus. |
nicolas-grekas added a commit that referenced this pull requestAug 16, 2017
This PR was merged into the 3.3 branch.Discussion----------Allow phpdocumentor/reflection-docblock 4| Q | A| ------------- | ---| Branch? | 3.3| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | none| License | MIT| Doc PR | N/AThe PHPDocumentor team bumped their reflection-docblock library to version 4 due to a breaking change that should not affect Symfony, as far as I can tell. This PR indicates compatibility with the new major version.Commits-------1a5fd79 Allow phpdocumentor/reflection-docblock 4.
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PHPDocumentor team bumped their reflection-docblock library to version 4 due to a breaking change that should not affect Symfony, as far as I can tell. This PR indicates compatibility with the new major version.