Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[SecurityBundle] resolve class name parameter inside AddSecurityVotersPass#23862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
pjarmalavicius commentedAug 11, 2017
Q | A |
---|---|
Branch? | 3.4 |
Bug fix? | yes |
New feature? | no |
BC breaks? | no |
Deprecations? | no |
Tests pass? | yes |
Fixed tickets | #23733 |
License | MIT |
Continuing discussion from the fixed ticket:
Resolving parameter in the existing pass could not break anything, only fix something that currently breaks (since |
Registering service class names was a convention which has been abandoned, we just stopped recommending to do so, we won't forbid it. |
…inside AddSecurityVotersPass
if (!is_a($class, VoterInterface::class, true)) { | ||
@trigger_error(sprintf('Using a security.voter tag on a class without implementing the %1$s is deprecated as of 3.4 and will be removed in 4.0. Implement the %1$s instead.', VoterInterface::class), E_USER_DEPRECATED); | ||
} | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
please don't remove the empty lines we have for readability.
Thank you@pjarmalavicius. |
…ddSecurityVotersPass (pjarmalavicius)This PR was squashed before being merged into the 3.4 branch (closes#23862).Discussion----------[SecurityBundle] resolve class name parameter inside AddSecurityVotersPass| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#23733| License | MITCommits-------a86bf52 [SecurityBundle] resolve class name parameter inside AddSecurityVotersPass