Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Filtering empty uuids in ORMQueryBuilderLoader.#23853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
mlazovla commentedAug 10, 2017
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #23808 |
| License | MIT |
| Doc PR | no |
nicolas-grekas commentedAug 12, 2017
Tobion commentedAug 12, 2017
Seems good enough. But#23808 (comment) would be the more correct solution. |
nicolas-grekas commentedAug 15, 2017
@mlazovla what's your stand about that "more correct solution"? |
mlazovla commentedAug 15, 2017
Maryo's new solution looks more universal than my PR. But I am not sure if it broke some edge case. |
nicolas-grekas commentedAug 25, 2017
So, should we merge and later on do what@maryo describes? Anyone willing to give it a try? |
javiereguiluz left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This definitely improves our current code and it looks correct. I'm not sure about the other proposed solutionhere and even its author mentions some potential problems with PostgreSQL.
fabpot commentedSep 11, 2017
Thank you@mlazovla. |
This PR was merged into the 2.7 branch.Discussion----------Filtering empty uuids in ORMQueryBuilderLoader.| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#23808| License | MIT| Doc PR | noCommits-------27e8cd2 Filtering empty uuids in ORMQueryBuilderLoader.