Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Revert "feature #21038 [FrameworkBundle] deprecated cache:clear with warmup (fabpot)"#23825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| * @param string $realCacheDir | ||
| * @param bool $enableOptionalWarmers | ||
| * | ||
| * @internal to be removed in 4.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
note that in 3.4, the command class is@final so we can still make them private in 4.0. I'll take care of it when merging up.
34369ad to9009970Comparefabpot commentedAug 18, 2017
I would not revert this in 3.3 as it helps with Flex. Here is the output right now when doing
As you can see, the warning helps explain the fatal error and provide a way to fix the issue. Instead, I would change the warning to explain that without the |
fabpot commentedAug 18, 2017
Investigating the issue a bit more, fixing the So, let's remove the |
fabpot commentedAug 18, 2017
Thank you@nicolas-grekas. |
…clear with warmup (fabpot)" (nicolas-grekas)This PR was merged into the 3.3 branch.Discussion----------Revert "feature#21038 [FrameworkBundle] deprecated cache:clear with warmup (fabpot)"This reverts commit3495b35, reversingchanges made to7f7b897.| Q | A| ------------- | ---| Branch? | 3.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#21038| License | MIT| Doc PR | -Sibling to#23792: there is no need to trigger the deprecation in 3.3 if we un-deprecate in 3.4.Commits-------9009970 Revert "feature#21038 [FrameworkBundle] deprecated cache:clear with warmup (fabpot)"
This reverts commit3495b35, reversing
changes made to7f7b897.
Sibling to#23792: there is no need to trigger the deprecation in 3.3 if we un-deprecate in 3.4.