Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[SecurityBundle] Rename init:acl to acl:init#23811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
ro0NL wants to merge1 commit intosymfony:3.4fromro0NL:acl/init-command
Closed

[SecurityBundle] Rename init:acl to acl:init#23811

ro0NL wants to merge1 commit intosymfony:3.4fromro0NL:acl/init-command

Conversation

@ro0NL
Copy link
Contributor

QA
Branch?3.4
Bug fix?no
New feature?no
BC breaks?no
Deprecations?yes
Tests pass?yes
Fixed tickets#...
LicenseMIT
Doc PRsymfony/symfony-docs#...

@fabpot
Copy link
Member

I'd would prefer that we finally move everything related to ACLs into another bundle that can be moved outside of Symfony core. Probably directly intosymfony/security-acl

@ro0NL
Copy link
ContributorAuthor

ro0NL commentedAug 6, 2017•
edited
Loading

Seesymfony/acl-bundle#2 :) but that needs a update anyway, so perhaps we can do this still here.

@nicolas-grekasnicolas-grekas added this to the3.4 milestoneAug 7, 2017
@linaori
Copy link
Contributor

I'll simply do the same changes in that bundle so they remain in sync

@ro0NL
Copy link
ContributorAuthor

👍 not sure how this goes.. if the commands stay in core till 4.0 i think the rename makes sense. In the acl bundle we can do the rename instantly i guess, without deprecation.

@linaori
Copy link
Contributor

@ro0NL I've simply copied your changes to keep them in sync, the deprecation makes sense as we can release a 4.0 variant of that bundle without problems. As long as people use 3.4 and use the ACL (bundle), they should be able to plug and play without BC breaks

@JasonCoal
Copy link

JasonCoal commentedAug 22, 2017 via email

Thanks for sending!
…
On Aug 22, 2017 at 3:50 AM, <Amrouche Hamza ***@***.***)> wrote:@Simperfit approved this pull request. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub (#23811 (review)), or mute the thread (https://github.com/notifications/unsubscribe-auth/AOXMGFzd6TCARO2fweBXNmige95Vz5wbks5saohPgaJpZM4OuxyS).

@chalasr
Copy link
Member

Let's deprecate ACL code and rename it in symfony/acl-bundle directly. See#24318

@ro0NL
Copy link
ContributorAuthor

Favoring#24318 :)

@ro0NLro0NL closed thisSep 25, 2017
@ro0NLro0NL deleted the acl/init-command branchSeptember 25, 2017 11:32
fabpot added a commit that referenced this pull requestSep 26, 2017
This PR was merged into the 3.4 branch.Discussion----------[SecurityBundle] Deprecate ACL related code| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | yes| Tests pass?   | yes/no| Fixed tickets | replaces#23811| License       | MIT| Doc PR        | todoNeedssymfony/acl-bundle#2Commits-------e3b7dc5 [SecurityBundle] Deprecate ACL related code
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@SimperfitSimperfitSimperfit approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

8 participants

@ro0NL@fabpot@linaori@JasonCoal@chalasr@Simperfit@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp