Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[VarDumper] Do not update source links in a new tab#23780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
Nyholm wants to merge4 commits intosymfony:3.4fromNyholm:patch-new-tab

Conversation

@Nyholm
Copy link
Member

QA
Branch?3.4
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets
LicenseMIT
Doc PR

When clicking on a source link in theprofiler_dump output we should not open a new tab. My IDE will open automatically and it will just leave an empty tab in my browser.

I could also argue for that wenever should open a new tab.

@chalasr
Copy link
Member

Experienced this too, never opening a new tab seems right to me (justctrl|cmd+click instead). Tests need to be updated

@Nyholm
Copy link
MemberAuthor

Thank you for the review. I've updated the PR and tests are all green now

@nicolas-grekas
Copy link
Member

nicolas-grekas commentedAug 3, 2017•
edited
Loading

I'm not sure about the experience when no IDE is configured: when you click, you loose the current state, so that the back button might be broken, isn't it?
When you have an IDE, this effectively means you open in another window btw...
I'd prefer an iframe in the current window personally.

yceruto reacted with thumbs up emoji

@nicolas-grekas
Copy link
Member

What about adding some logic so that ide links don't have the target set?
Note that there are more IDE links than the ones generated by VarDumper.

@nicolas-grekasnicolas-grekas added this to the3.4 milestoneAug 5, 2017
@Nyholm
Copy link
MemberAuthor

Sure, I'll look into that. Thanks

@ro0NL
Copy link
Contributor

For the iframe approach, have a look at#21045 it probably works for dumps as well :)

@nicolas-grekas
Copy link
Member

Closing as this is not the approach comments direct to.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@javiereguiluzjaviereguiluzjaviereguiluz approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

6 participants

@Nyholm@chalasr@nicolas-grekas@ro0NL@javiereguiluz@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp