Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Ignore memcached missing key error on session destroy#23752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
13b6657 tod69ff13Compare| return$this->memcached->delete($this->prefix.$sessionId); | ||
| $result =$this->memcached->delete($this->prefix.$sessionId); | ||
| if (!$result &&$this->memcached->getResultCode() == \Memcached::RES_NOTFOUND) { |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
return $result || $this->memcached->getResultCode() == \Memcached::RES_NOTFOUND;
d69ff13 to29538b6Comparefabpot approved these changesAug 9, 2017
Member
fabpot commentedAug 9, 2017
Thank you@jderusse. |
fabpot added a commit that referenced this pull requestAug 9, 2017
…russe)This PR was merged into the 2.7 branch.Discussion----------Ignore memcached missing key error on session destroy| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#18574| License | MIT| Doc PR | NASince PHP 7 session_regenerate_id triggers a warning when the session is not started.This PR, changes the behaviours of session_destroy in the `MemcachedSessionHandler` by returning true when the user try to delete a non-existing session.Other handler:- LegacyPdoSessionHandler => don't check if key exists- MongoDbSessionHandler => don't check if key exists- NullSessionHandler => always true- PdoSessionHandler => don't check if key existsCommits-------29538b6 Ignore memcached missing key error on dession destroy
This was referencedAug 28, 2017
Merged
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Since PHP 7 session_regenerate_id triggers a warning when the session is not started.
This PR, changes the behaviours of session_destroy in the
MemcachedSessionHandlerby returning true when the user try to delete a non-existing session.Other handler: