Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[WebProfilerBundle] Removed the deprecated web_profiler.position option#23728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
fabpot added a commit that referenced this pull requestSep 7, 2017
…iluz)This PR was squashed before being merged into the 3.4 branch (closes#24080).Discussion----------Deprecated the web_profiler.position option| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | no| New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files -->| BC breaks? | no| Deprecations? | yes| Tests pass? | yes| Fixed tickets |#23528| License | MIT| Doc PR | -Related to#23728, which removes the feature for Symfony 4.0.Commits-------53387b4 Deprecated the web_profiler.position option
Member
nicolas-grekas commentedSep 9, 2017
Thank you@javiereguiluz. |
nicolas-grekas added a commit that referenced this pull requestSep 9, 2017
…r.position option (javiereguiluz)This PR was merged into the 4.0-dev branch.Discussion----------[WebProfilerBundle] Removed the deprecated web_profiler.position option| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | yes| Tests pass? | yes| Fixed tickets |#23528| License | MIT| Doc PR | -This PR shows the things we could remove if we accept#23528. If it's accepted, I'd create the PR for 3.4 deprecating the feature instead of removing it.Commits-------cafdf2b [WebProfilerBundle] Deprecated the web_profiler.position option
Merged
ostrolucky pushed a commit to ostrolucky/symfony that referenced this pull requestMar 25, 2018
…viereguiluz)This PR was squashed before being merged into the 3.4 branch (closessymfony#24080).Discussion----------Deprecated the web_profiler.position option| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | no| New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files -->| BC breaks? | no| Deprecations? | yes| Tests pass? | yes| Fixed tickets |symfony#23528| License | MIT| Doc PR | -Related tosymfony#23728, which removes the feature for Symfony 4.0.Commits-------53387b4 Deprecated the web_profiler.position option
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR shows the things we could remove if we accept#23528. If it's accepted, I'd create the PR for 3.4 deprecating the feature instead of removing it.