Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Lock] Deprecate Filesystem/LockHandler#23724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
chalasr left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The console composer.json needs an update (replacing thefilesystem requirement bylock)
| useSymfony\Component\Filesystem\Exception\IOException; | ||
| /** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
* @deprecated since ...
| namespaceSymfony\Component\Filesystem; | ||
| @trigger_error(sprintf('The %s class is deprecated since version 3.4 and will be removed in 4.0. Use the SemaphoreStore or FlockStore class instead.', LockHandler::class),E_USER_DEPRECATED); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
getting this notice while using the standalone filesystem, I would try to find the SemaphoreStore in the filesystem component. I would use FQCNs or prependLock here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
right
UPGRADE-3.4.md Outdated
| class has been deprecated and will be removed in 4.0. Use the | ||
| `Symfony\Component\Translation\DependencyInjection\TranslatorPass` class instead. | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
should be reverted
1dde55b to33ab87fComparechalasr commentedJul 31, 2017
fabbot needs some love |
chalasr left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
fabpot commentedAug 1, 2017
Thank you@jderusse. |
This PR was merged into the 3.4 branch.Discussion----------[Lock] Deprecate Filesystem/LockHandler| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | yes| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |symfony/symfony-docs#8243This PR deprecate the `Filesystem\LockHandler` in favor of `Lock\SemaphoreStore` and `Lock\FlockStore`.Commits-------67ecc71 Deprecate Filesystem/LockHandler
This PR was merged into the 4.0-dev branch.Discussion----------[Lock] Remove Filesystem\LockHandler| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | yes| Deprecations? | no| Tests pass? | not yet| Fixed tickets | /| License | MIT| Doc PR | /This PR remove the deprecated LockHandler by#23724Test won't pass as long as the branch 3.4 (and fixed deprecated tests) is not merged back into master.Commits-------39ab789 Remove Filesystem\LockHandler
This PR was merged into the 4.0-dev branch.Discussion----------[Lock] Remove old version check| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#23724| License | MIT| Doc PR | /Because minimal required version PHP is currenty 7.1.3.ping@jderusseCommits-------d817f98 Remove old version check
…eguiluz)This PR was merged into the 3.4 branch.Discussion----------[Lock] Deprecate Filesystem/LockHandlerThis PR deprecate the Filesystem\LockHandler in favor of Lock\SemaphoreStore and Lock\FlockStore.see:symfony/symfony#23724Commits-------cb771c3 Rewordaf6dc34 Minor reword800bdd7 Deprecate Filesystem/LockHandler
Uh oh!
There was an error while loading.Please reload this page.
This PR deprecate the
Filesystem\LockHandlerin favor ofLock\SemaphoreStoreandLock\FlockStore.