Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Autoconfigure instances of ArgumentValueResolverInterface#23719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:3.4fromBPScott:autoconfig-argresolver
Aug 3, 2017
Merged

Autoconfigure instances of ArgumentValueResolverInterface#23719

nicolas-grekas merged 1 commit intosymfony:3.4fromBPScott:autoconfig-argresolver
Aug 3, 2017

Conversation

@BPScott
Copy link
Contributor

@BPScottBPScott commentedJul 30, 2017•
edited
Loading

QA
Branch?3.4
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#23701
LicenseMIT
Doc PRn/a

Autoconfigure instances ofSymfony\Component\HttpKernel\Controller\ArgumentValueResolverInterface so they get thecontroller.argument_value_resolver tag automatically added to them.

This avoids avoid having to tag each resolver or add an_instanceof configuration such as

_instanceof:Symfony\Component\HttpKernel\Controller\ArgumentValueResolverInterface:tags:[controller.argument_value_resolver]

@chalasr
Copy link
Member

This is a new feature so it must target 3.4.

jvasseur reacted with thumbs up emoji

@BPScott
Copy link
ContributorAuthor

BPScott commentedJul 31, 2017•
edited
Loading

Ah rats, I was in two minds about if this constituted a new feature or a bug. I leant towards bug for 3.3.x as I hoped this could be interpreted as "it should have been there at the start but it was missed". What do you reckon@weaverryan?

@fabpot
Copy link
Member

@BPScott Even if it should have been part of 3.3, we missed that and Symfony is perfectly usable without it. So, that qualifies as a new feature.

Add the controller.argument_value_resolver tag to instances ofArgumentValueResolverInterface
@BPScottBPScott changed the base branch from3.3 to3.4August 1, 2017 09:21
@BPScott
Copy link
ContributorAuthor

Thank you for the clarification@chalasr and@fabpot, I'll keep that in mind for any future PRs.

I've rebased and retargeted this PR to 3.4

@nicolas-grekas
Copy link
Member

Thank you@BPScott.

@nicolas-grekasnicolas-grekas merged commitee4dc20 intosymfony:3.4Aug 3, 2017
nicolas-grekas added a commit that referenced this pull requestAug 3, 2017
…ace (BPScott)This PR was merged into the 3.4 branch.Discussion----------Autoconfigure instances of ArgumentValueResolverInterface| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#23701| License       | MIT| Doc PR        | n/aAutoconfigure instances of `Symfony\Component\HttpKernel\Controller\ArgumentValueResolverInterface` so they get the `controller.argument_value_resolver` tag automatically added to them.This avoids avoid having to tag each resolver or add an `_instanceof` configuration such as```yaml_instanceof:    Symfony\Component\HttpKernel\Controller\ArgumentValueResolverInterface:        tags: [controller.argument_value_resolver]```Commits-------ee4dc20 Autoconfigure instances of ArgumentValueResolverInterface
This was referencedOct 18, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@weaverryanweaverryanweaverryan approved these changes

@xabbuhxabbuhxabbuh approved these changes

@chalasrchalasrchalasr approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

8 participants

@BPScott@chalasr@fabpot@nicolas-grekas@weaverryan@xabbuh@ogizanagi@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp