Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Form] Add notice to upgrade to PHP v7.0.8+#23705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedJul 28, 2017
@symfony/mergers should be mergedbefore releasing v3.3.6 |
fabpot commentedJul 28, 2017
Thank you@nicolas-grekas. |
This PR was merged into the 3.3 branch.Discussion----------[Form] Add notice to upgrade to PHP v7.0.8+| Q | A| ------------- | ---| Branch? | 3.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#22973| License | MIT| Doc PR | -So that PHP7 < 7.0.8 users get a notice about the issue.Commits-------0347e5a [Form] Add notice to upgrade to PHP v7.0.8+
| publicfunctioncollect(Request$request,Response$response,\Exception$exception =null) | ||
| { | ||
| if (70000 <= \PHP_VERSION_ID && \PHP_VERSION_ID <70800) { | ||
| @trigger_error('A bug in PHP v7.0.0 to v7.0.7 is breaking the Form panel, please upgrade to v7.0.8 or more.',E_USER_DEPRECATED); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
s/more/higher/ ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Indeed, that's better. Done ina6f44d2. Thanks for the suggestion.
So that PHP7 < 7.0.8 users get a notice about the issue.