Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Bump minimal PHP version to ^5.5.9|>=7.0.8#23703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
curry684 commentedJul 28, 2017
This will just confuse users with <7.0.8 about why they're not getting important security updates anymore. |
nicolas-grekas commentedJul 28, 2017
@curry684 truth is, serializing is broken with PHP <7.0.8, so everybody should reject these versions. It's only losely related to the linked issue. |
curry684 commentedJul 28, 2017
I completely agree with the solution and change, just not some of its possible side effects. If 3.3.6 contains a warning for PHP <7.0.8, and we then remove that in 3.3.7 and 3.4.0 along with the Composer bump the issue is fixed,and users that are upgrading Symfony but not PHP have a clear end-of-road warning. |
nicolas-grekas commentedJul 28, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
curry684 commentedJul 28, 2017
Cheers, well solved. |
| publicfunctioncollect(Request$request,Response$response,\Exception$exception =null) | ||
| { | ||
| if (70000 <= \PHP_VERSION_ID && \PHP_VERSION_ID <70800) { | ||
| @trigger_error('A bug in PHP 7.0.0 to 7.0.7 is breaking the Form panel, please upgrade to 7.0.8 or higher.',E_USER_DEPRECATED); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
now removed
This PR was merged into the 3.3 branch.Discussion----------Bump minimal PHP version to ^5.5.9|>=7.0.8| Q | A| ------------- | ---| Branch? | 3.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#22973| License | MIT| Doc PR | -As spotted in the linked issue, because ofhttps://bugs.php.net/72229.Commits-------2282a6f Bump minimal PHP version to ^5.5.9|>=7.0.8
As spotted in the linked issue, because ofhttps://bugs.php.net/72229.