Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Console][WebServerBundle] Use "exec" when possible#23686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedJul 26, 2017
| Q | A |
|---|---|
| Branch? | 3.3 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #23568 |
| License | MIT |
| Doc PR | - |
439d15c to7b6d894Compare| "require": { | ||
| "php":">=5.5.9", | ||
| "symfony/console":"~2.8.8|~3.0.8|~3.1.2|~3.2", | ||
| "symfony/console":"~3.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
there is no need to keep pre-3.3 deps for 3.3-introduced bundles IMHO, that makes things easier
robfrawley commentedJul 26, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Confirming this PR does indeed fix the inability to properly kill the web server process via the |
| $builder->setTimeout(null); | ||
| $process =newProcess(array($binary,'-S',$config->getAddress(),$config->getRouter())); | ||
| $process->setWorkingDirectory($config->getDocumentRoot()); | ||
| $process->setTimeout(null); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
return new Process(array($binary, '-S', $config->getAddress(), $config->getRouter()), $config->getDocumentRoot(), null, null); btw?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
More readable as is to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
right!
fabpot commentedJul 27, 2017
Thank you@nicolas-grekas. |
…as-grekas)This PR was merged into the 3.3 branch.Discussion----------[Console][WebServerBundle] Use "exec" when possible| Q | A| ------------- | ---| Branch? | 3.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#23568| License | MIT| Doc PR | -Commits-------7b6d894 [Console][WebServerBundle] Use "exec" when possible