Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[PropertyInfo] Add hassers for accessors prefixes#23617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ContributorAuthor
sebdec commentedJul 21, 2017
maybe it can be defined as a bug fix |
Contributor
jakzal commentedOct 25, 2017
Would be nice to have it. It's a new feature though. |
fabpot approved these changesFeb 7, 2018
Member
fabpot left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
for master
Member
fabpot commentedFeb 7, 2018
Thank you@sebdec. |
fabpot added a commit that referenced this pull requestFeb 7, 2018
…dec)This PR was submitted for the 3.3 branch but it was squashed and merged into the 4.1-dev branch instead (closes#23617).Discussion----------[PropertyInfo] Add hassers for accessors prefixes| Q | A| ------------- | ---| Branch? | 3.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | None| License | MIT| Doc PR | -In the component PropertyInfoIn the class ReflectionExtractor Add hassers in the accessors prefixesBecause I think it's common to have readable properties with method like this:hasChildren()Commits-------03bce5e [PropertyInfo] Add hassers for accessors prefixes
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
In the component PropertyInfo
In the class ReflectionExtractor Add hassers in the accessors prefixes
Because I think it's common to have readable properties with method like this:
hasChildren()