Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[WebProfilerBundle][TwigBundle] Fix infinite js loop on exception pages#23577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| var toggleLinks=document.querySelectorAll('.sf-toggle a'); | ||
| for (vari=0;i<toggleLinks.length;i++) { | ||
| addEventListener(toggleLinks[i],'click',function(e) { | ||
| for (varj=0;j<toggleLinks.length;j++) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This change is not needed, right? Herei is not defined. I supposed you did that for consistency with the other file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good catch actually: There is no reason there is any difference between the two files. The right fix is that it shouldn't have been called within the above loop at the first place.
fabpot commentedJul 19, 2017
Thank you@ogizanagi. |
…ception pages (ogizanagi)This PR was merged into the 3.3 branch.Discussion----------[WebProfilerBundle][TwigBundle] Fix infinite js loop on exception pages| Q | A| ------------- | ---| Branch? | 3.3 <!-- see comment below -->| Bug fix? | yes| New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files -->| BC breaks? | no| Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->| Tests pass? | yes| Fixed tickets |#23566 <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR | N/ACommits-------295fda9 [WebProfilerBundle][TwigBundle] Fix infinite js loop on exception pages
Uh oh!
There was an error while loading.Please reload this page.