Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[VarDumper] Move locale sniffing to dump() time#23574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| */ | ||
| publicfunctiondump(Data$data,$output =null) | ||
| { | ||
| $this->decimalPoint =strval(0.5); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
sorry fabbot, but I really want strval here, to prevent any optim by opcache :)
2605cf0 tof77161bCompare| $this->decimalPoint =(string)0.5; | ||
| $this->decimalPoint =$this->decimalPoint[1]; | ||
| $this->decimalPoint =localeconv(); | ||
| $this->decimalPoint =$this->decimalPoint['decimal_point']; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why keep the logic here as well? Can't we remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
For BC, the property is protected.
fabpot commentedJul 19, 2017
Thank you@nicolas-grekas. |
…rekas)This PR was merged into the 2.7 branch.Discussion----------[VarDumper] Move locale sniffing to dump() time| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#23572| License | MIT| Doc PR | -Commits-------eed8a51 [VarDumper] Move locale sniffing to dump() time
Uh oh!
There was an error while loading.Please reload this page.