Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Console] Add a factory command loader for standalone application with lazy-loading needs#23510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
chalasr merged 1 commit intosymfony:3.4fromogizanagi:feature/console/factory_loader
Jul 19, 2017
Merged

[Console] Add a factory command loader for standalone application with lazy-loading needs#23510

chalasr merged 1 commit intosymfony:3.4fromogizanagi:feature/console/factory_loader
Jul 19, 2017

Conversation

@ogizanagi
Copy link
Contributor

@ogizanagiogizanagi commentedJul 14, 2017
edited
Loading

QA
Branch?3.4
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes (failure unrelated)
Fixed tickets#22734 (comment)
LicenseMIT
Doc PRtodo (withsymfony/symfony-docs#8147)

So standalone applications can also benefit from the lazy loading feature without requiring a PSR-11 implementation specifically for this need.

The loader does not memoize any resolved command from factories, as it's theApplication responsibility and theContainerCommandLoader does not either (the PSR-11 does not enforce two successive calls to return the same value).

yceruto, sstok, mnapoli, and chalasr reacted with thumbs up emoji
Copy link
Member

@xabbuhxabbuh left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can you add the missing changelog entry?

@xabbuhxabbuh added this to the3.4 milestoneJul 15, 2017
@ogizanagi
Copy link
ContributorAuthor

Changelog entry updated

@chalasr
Copy link
Member

Thank you@ogizanagi.

@chalasrchalasr merged commit9b40b4a intosymfony:3.4Jul 19, 2017
chalasr pushed a commit that referenced this pull requestJul 19, 2017
…application with lazy-loading needs (ogizanagi)This PR was merged into the 3.4 branch.Discussion----------[Console] Add a factory command loader for standalone application with lazy-loading needs| Q             | A| ------------- | ---| Branch?       | 3.4 <!-- see comment below -->| Bug fix?      | no| New feature?  | yes <!-- don't forget updating src/**/CHANGELOG.md files -->| BC breaks?    | no| Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->| Tests pass?   | yes (failure unrelated)| Fixed tickets |#22734 (comment) <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | todo (withsymfony/symfony-docs#8147)So standalone applications can also benefit from the lazy loading feature without requiring a PSR-11 implementation specifically for this need.The loader does not memoize any resolved command from factories, as it's the `Application` responsibility and the `ContainerCommandLoader` does not either (the PSR-11 does not enforce two successive calls to return the same value).Commits-------9b40b4a [Console] Add a factory command loader for standalone application with lazy-loading needs
@ogizanagiogizanagi deleted the feature/console/factory_loader branchJuly 19, 2017 13:18
This was referencedOct 18, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@xabbuhxabbuhxabbuh approved these changes

@chalasrchalasrchalasr approved these changes

+1 more reviewer

@ro0NLro0NLro0NL approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

6 participants

@ogizanagi@chalasr@nicolas-grekas@ro0NL@xabbuh@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp