Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Console] Add a factory command loader for standalone application with lazy-loading needs#23510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ro0NL approved these changesJul 14, 2017
Member
xabbuh left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can you add the missing changelog entry?
ContributorAuthor
ogizanagi commentedJul 15, 2017
Changelog entry updated |
…h lazy-loading needs
nicolas-grekas approved these changesJul 15, 2017
xabbuh approved these changesJul 15, 2017
chalasr approved these changesJul 17, 2017
Member
chalasr commentedJul 19, 2017
Thank you@ogizanagi. |
chalasr pushed a commit that referenced this pull requestJul 19, 2017
…application with lazy-loading needs (ogizanagi)This PR was merged into the 3.4 branch.Discussion----------[Console] Add a factory command loader for standalone application with lazy-loading needs| Q | A| ------------- | ---| Branch? | 3.4 <!-- see comment below -->| Bug fix? | no| New feature? | yes <!-- don't forget updating src/**/CHANGELOG.md files -->| BC breaks? | no| Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->| Tests pass? | yes (failure unrelated)| Fixed tickets |#22734 (comment) <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR | todo (withsymfony/symfony-docs#8147)So standalone applications can also benefit from the lazy loading feature without requiring a PSR-11 implementation specifically for this need.The loader does not memoize any resolved command from factories, as it's the `Application` responsibility and the `ContainerCommandLoader` does not either (the PSR-11 does not enforce two successive calls to return the same value).Commits-------9b40b4a [Console] Add a factory command loader for standalone application with lazy-loading needs
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
So standalone applications can also benefit from the lazy loading feature without requiring a PSR-11 implementation specifically for this need.
The loader does not memoize any resolved command from factories, as it's the
Applicationresponsibility and theContainerCommandLoaderdoes not either (the PSR-11 does not enforce two successive calls to return the same value).