NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[DI] Handle root namespace in service definitions#23468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

ro0NL wants to merge2 commits intosymfony:2.7fromro0NL:di/root-namespace

Closed

[DI] Handle root namespace in service definitions#23468

ro0NL wants to merge2 commits intosymfony:2.7fromro0NL:di/root-namespace

Conversation

Copy link

Contributor

ro0NL commentedJul 10, 2017•
edited
Loading

Q	A
Branch?	2.7
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#...
License	MIT
Doc PR	symfony/symfony-docs#...

Fixes

Cannot dump definition because of invalid class name ('\\stdClass')

for

services:foo:{class: '\stdClass' }

ContainerBuilder allows it, soPhpDumper should as well.

carsonbot added Status: Needs Review DependencyInjection Bug labels

Jul 10, 2017

[DI] Handle root namespace in service definitions

f53147d

nicolas-grekas added this to the2.7 milestone

Jul 11, 2017

nicolas-grekas approved these changes

Jul 11, 2017

View reviewed changes

stloyd reviewed

Jul 11, 2017

View reviewed changes

src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php Outdated

		return'\\'.substr(str_replace('\\\\','\\',$class),1, -1);
		$class =substr(str_replace('\\\\','\\',$class),1, -1);

		return'\\' ===substr($class,0,1) ?$class :'\\'.$class;

Copy link

Contributor

stloydJul 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

0 === strpos($class, '\\')

optimize

60b371d

fabpot approved these changes

Jul 12, 2017

View reviewed changes

Copy link

Member

nicolas-grekas commentedJul 12, 2017

Thank you@ro0NL.

nicolas-grekas added a commit that referenced this pull request

Jul 12, 2017

bug#23468[DI] Handle root namespace in service definitions (ro0NL)

87a6845

This PR was squashed before being merged into the 2.7 branch (closes#23468).Discussion----------[DI] Handle root namespace in service definitions| Q             | A| ------------- | ---| Branch?       | 2.7| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | symfony/symfony-docs#... <!--highly recommended for new features-->Fixes```Cannot dump definition because of invalid class name ('\\stdClass')```for```yamlservices:    foo: {class: '\stdClass' }````ContainerBuilder` allows it, so `PhpDumper` should as well.Commits-------05170c8 [DI] Handle root namespace in service definitions

nicolas-grekas closed this

Jul 12, 2017