Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[TwigBridge] cleaner implementation of the TwigRenderer#23435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Tobion commentedJul 6, 2017
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #23432 (comment) |
| License | MIT |
| Doc PR |
| /** | ||
| * Returns the engine used by this renderer. | ||
| * | ||
| * @return TwigRendererEngineInterface The renderer engine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this is added so that static code analysis and autocomplete works (which I assume is the also the only reason the private engine property was overwritten)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
IMO adding autocomplete for deprecated method isn't worth it. It seems autocomplete for it never worked.
nicolas-grekas commentedJul 13, 2017
Thank you@Tobion. |
…(Tobion)This PR was merged into the 2.7 branch.Discussion----------[TwigBridge] cleaner implementation of the TwigRenderer| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | no| New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files -->| BC breaks? | no| Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->| Tests pass? | yes| Fixed tickets |#23432 (comment)| License | MIT| Doc PR |<!--- Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too).- Features and deprecations must be submitted against the 3.4, legacy code removals go to the master branch.- Please fill in this template according to the PR you're about to submit.- Replace this comment by a description of what your PR is solving.-->Commits-------c7c5ba8 [TwigBridge] cleaner implementation of the TwigRenderer