Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[TwigBridge] Remove deprecated feature#23432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
maidmaid commentedJul 6, 2017
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | yes |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #20769#20093 |
| License | MIT |
| Doc PR | / |
maidmaid commentedJul 6, 2017
By removing this deprecations, the class TwigRendererextends FormRendererimplements FormRendererInterface {} What about deprecate this class in favor of |
| * @author Bernhard Schussek <bschussek@gmail.com> | ||
| */ | ||
| class TwigRendererextends FormRendererimplementsTwigRendererInterface | ||
| class TwigRendererextends FormRendererimplementsFormRendererInterface |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
FormRendererInterface is already implemented byFormRenderer
xabbuh commentedJul 6, 2017
Duplicate of#22783? :) |
| */ | ||
| publicfunctionsetEnvironment(Environment$environment) | ||
| { | ||
| $this->engine->setEnvironment($environment); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The engine property can be removed in earlier versions as this can be placed by$this->getEngine()->setEnvironment() or am I missing something?
maidmaid commentedJul 6, 2017
@xabbuh exact duplicate 😳 sorry! |
Tobion commentedJul 6, 2017
@xabbuh that explains why I had a dejavu when reviewing this ^^ |
…(Tobion)This PR was merged into the 2.7 branch.Discussion----------[TwigBridge] cleaner implementation of the TwigRenderer| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | no| New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files -->| BC breaks? | no| Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->| Tests pass? | yes| Fixed tickets |#23432 (comment)| License | MIT| Doc PR |<!--- Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too).- Features and deprecations must be submitted against the 3.4, legacy code removals go to the master branch.- Please fill in this template according to the PR you're about to submit.- Replace this comment by a description of what your PR is solving.-->Commits-------c7c5ba8 [TwigBridge] cleaner implementation of the TwigRenderer