Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
require the XML PHP extension#23421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| ], | ||
| "require": { | ||
| "php":">=5.3.9", | ||
| "ext-xml":"*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This should be removed as DI is an optional dep.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Not sure about this. Which part of the DebugBundle would you use without the DI extension?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ok, let's keep it
| ], | ||
| "require": { | ||
| "php":">=5.3.9", | ||
| "ext-xml":"*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I would keep it as using the bundle without DI is probably not a use case anyway.
| ], | ||
| "require": { | ||
| "php":">=5.3.9", | ||
| "ext-xml":"*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This should be removed as DI is an optional dep.
| ], | ||
| "require": { | ||
| "php":">=5.3.9", | ||
| "ext-xml":"*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This should be removed as DI is an optional dep.
Tobion commentedJul 6, 2017
Why exclude TwigBundle and WebProfilerBundle? |
Tobion commentedJul 6, 2017
Nvm, meant to be optional apparently. |
fabpot commentedJul 6, 2017
@Tobion TwigBundle and WebProfilerBundle are used by Silex without the Symfony container. |
fabpot commentedJul 6, 2017
Thank you@xabbuh. |
This PR was merged into the 2.7 branch.Discussion----------require the XML PHP extension| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#22676 (comment),symfony/symfony-standard#1099| License | MIT| Doc PR |I suggest to either revert#22676 or to be consistent and require the XML extension in all bundles as well as in the `symfony/symfony` package.Commits-------032e654 require the XML PHP extension
I suggest to either revert#22676 or to be consistent and require the XML extension in all bundles as well as in the
symfony/symfonypackage.