Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[WebProfilerBundle] Fix full sized dump hovering in toolbar#23330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
javiereguiluz merged 1 commit intosymfony:2.8fromogizanagi:fix/2.8/profiler_toolbar_dumpJul 19, 2017
Merged
[WebProfilerBundle] Fix full sized dump hovering in toolbar#23330
javiereguiluz merged 1 commit intosymfony:2.8fromogizanagi:fix/2.8/profiler_toolbar_dumpJul 19, 2017
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ContributorAuthor
ogizanagi commentedJun 29, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
After some more investigations, it seems it doesn't happen on a fresh install. It happens on symfony-demo. The cause seems to be a conflict somewhere with bootstrap-sass, as removing it solves the issue. |
Member
fabpot commentedJul 3, 2017
ping@javiereguiluz |
ContributorAuthor
ogizanagi commentedJul 19, 2017
@javiereguiluz : What do you think about merging this one? It's not ideal, because I didn't really identify the conflicting css rules leading to this strange behavior, but at least this patch has been proven effective for everyone in the referenced issue. |
javiereguiluz approved these changesJul 19, 2017
Member
javiereguiluz commentedJul 19, 2017
@ogizanagi you are right. Let's merge this. Thanks! |
Member
javiereguiluz commentedJul 19, 2017
Thanks Maxime. |
javiereguiluz added a commit that referenced this pull requestJul 19, 2017
…r (ogizanagi)This PR was merged into the 2.8 branch.Discussion----------[WebProfilerBundle] Fix full sized dump hovering in toolbar| Q | A| ------------- | ---| Branch? | 2.8 <!-- see comment below -->| Bug fix? | yes| New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files -->| BC breaks? | no| Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->| Tests pass? | yes| Fixed tickets |#23563 <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR | N/ASince#22953, the dump block shown on hovering the toolbar item takes the full width. But at least on OS X chrome, safari and firefox, the behavior is buggy and makes it unusable as the cursor can't reach the dumped content:Honestly, I don't really understand the issue here and tried some tweaks until it works everywhere, (including trying to add a `.no-resize` class on `sf-toolbar-info` to avoid executing the related js event listener in case it was conflicting).As shown in the screenshot, it also fixes the case where the dump wasn't full width under a certain size.Commits-------28930c5 [WebProfilerBundle] Fix full sized dump hovering in toolbar
This was referencedAug 1, 2017
Merged
Merged
Merged
Contributor
MatTheCat commentedAug 2, 2017
What is the meaning ofthis piece of JavaScript? I think the issue comes from the fact it assumes all Proper quick fix: .sf-toolbar-block.sf-toolbar-block-dump .sf-toolbar-info {+ left: 0 !important; max-width: none;- right: 0;+ right: 0 !important;} |
ostrolucky pushed a commit to ostrolucky/symfony that referenced this pull requestMar 25, 2018
… toolbar (ogizanagi)This PR was merged into the 2.8 branch.Discussion----------[WebProfilerBundle] Fix full sized dump hovering in toolbar| Q | A| ------------- | ---| Branch? | 2.8 <!-- see comment below -->| Bug fix? | yes| New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files -->| BC breaks? | no| Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->| Tests pass? | yes| Fixed tickets |symfony#23563 <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR | N/ASincesymfony#22953, the dump block shown on hovering the toolbar item takes the full width. But at least on OS X chrome, safari and firefox, the behavior is buggy and makes it unusable as the cursor can't reach the dumped content:Honestly, I don't really understand the issue here and tried some tweaks until it works everywhere, (including trying to add a `.no-resize` class on `sf-toolbar-info` to avoid executing the related js event listener in case it was conflicting).As shown in the screenshot, it also fixes the case where the dump wasn't full width under a certain size.Commits-------28930c5 [WebProfilerBundle] Fix full sized dump hovering in toolbar
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Since#22953, the dump block shown on hovering the toolbar item takes the full width. But at least on OS X chrome, safari and firefox, the behavior is buggy and makes it unusable as the cursor can't reach the dumped content:
Honestly, I don't really understand the issue here and tried some tweaks until it works everywhere, (including trying to add a
.no-resizeclass onsf-toolbar-infoto avoid executing the related js event listener in case it was conflicting).As shown in the screenshot, it also fixes the case where the dump wasn't full width under a certain size.