Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Cache] fix cleanup of expired items for PdoAdapter#23326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
23416fd to6fd9516Compare| * @throws InvalidArgumentException When namespace contains invalid characters | ||
| * @throws\InvalidArgumentException When first argument is not PDO nor Connection nor string | ||
| * @throws\InvalidArgumentException When PDO error mode is not PDO::ERRMODE_EXCEPTION | ||
| * @throws\InvalidArgumentException When namespace contains invalid characters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
These were OK ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ah you are right! Did not see theuse Symfony\Component\Cache\Exception\InvalidArgumentException 😋
fabpot commentedJul 3, 2017
Thank you@dmaicher. |
…her)This PR was merged into the 3.2 branch.Discussion----------[Cache] fix cleanup of expired items for PdoAdapter| Q | A| ------------- | ---| Branch? | 3.2| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#23313| License | MIT| Doc PR | -This fixes the query being executed to cleanup expired items from the `cache_items` table using the `PdoAdapter`.I also added a test case to make sure we do the cleanup successfully.Commits-------c183b0e [Cache] fix cleanup of expired items for PdoAdapter
This fixes the query being executed to cleanup expired items from the
cache_itemstable using thePdoAdapter.I also added a test case to make sure we do the cleanup successfully.