Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Workflow] Added more events to the announce function#23299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ostrolucky left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Even if you chose the code change, remember that docs need to be updated, because they currently state "announce: Triggered once for each workflow that now is available for the object."
Nyholm commentedJun 26, 2017
Thank you@ostrolucky for your review. I will send a PR to the docs. Also, we need to make sure we do not "announce" before the guard events. The guard events may block the transition. |
This reverts commit30728d9.
Nyholm commentedJun 26, 2017
Sorry, I was wrong in my last comment and commit. I reverted it, the PR is now unchanged since you reviewed it. I made a small PR to the docs to address the issue@ostrolucky highlighted. |
lyrixx commentedJun 26, 2017
Thanks for fixing this bug@Nyholm. |
…olm)This PR was submitted for the master branch but it was merged into the 3.2 branch instead (closes#23299).Discussion----------[Workflow] Added more events to the announce function| Q | A| ------------- | ---| Branch? | 3.2| Bug fix? | yes/no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#23275| License | MIT| Doc PR |#8087This PR willfix#23275The documentation states that we dispatch events `workflow.announce` and `workflow.[name].announce`. It was me who wrongly added it to the docs... sorry about that.We could either: Change the docs or add these events. I choose to add these event to the source since the same events are dispatched for "guard", "leave", "transition", "enter" and "entered".Commits-------c5042f3 [Workflow] Added more events to the announce function
lyrixx commentedJun 26, 2017
I merged this PR in the 3.2 branch instead of master. |
Nyholm commentedJun 26, 2017
Thank you for merging. |
This PR was submitted for the 3.3 branch but it was merged into the 3.2 branch instead (closes#8087).Discussion----------[Workflow] Updated language for annouce eventRelated tosymfony/symfony#23299Commits-------9b6dce4 Updated language for annouce event
Uh oh!
There was an error while loading.Please reload this page.
This PR willfix#23275
The documentation states that we dispatch events
workflow.announceandworkflow.[name].announce. It was me who wrongly added it to the docs... sorry about that.We could either: Change the docs or add these events. I choose to add these event to the source since the same events are dispatched for "guard", "leave", "transition", "enter" and "entered".