Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[WebProfilerBundle] Fix css trick used for offsetting html anchor from fixed header#23296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
javiereguiluz approved these changesJun 25, 2017
fabpot approved these changesJul 3, 2017
Member
fabpot commentedJul 3, 2017
Thank you@ogizanagi. |
fabpot added a commit that referenced this pull requestJul 3, 2017
… anchor from fixed header (ogizanagi)This PR was merged into the 3.2 branch.Discussion----------[WebProfilerBundle] Fix css trick used for offsetting html anchor from fixed header| Q | A| ------------- | ---| Branch? | 3.2 <!-- see comment below -->| Bug fix? | yes (minor DX)| New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files -->| BC breaks? | no| Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->| Tests pass? | yes| Fixed tickets | N/A <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR | N/AThe css trick used was incomplete (missing `display: block;`), which is probably why it has been changed inhttps://github.com/symfony/symfony/pull/22455/files#diff-7d417267ae50374356ab990c58233a9bR67.Despite the current version works well, it behaves quite ugly specifically on Chrome:|Before|After||--|--||||For ref about the trick:https://stackoverflow.com/questions/10732690/offsetting-an-html-anchor-to-adjust-for-fixed-header/13184714#13184714Commits-------9f9697a [WebProfilerBundle] Fix css trick used for offsetting html anchor from fixed header
%7c%21%5bjuin-25-2017){kind=link}
%7c){kind=link}
nicolas-grekas added a commit that referenced this pull requestFeb 19, 2018
This PR was squashed before being merged into the 3.4 branch (closes#26230).Discussion----------[WebProfilerBundle] Fix anchor CSS| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes/no| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR | symfony/symfony-docs#... <!--highly recommended for new features-->Empty source lines overlap in `/_profiler/open?file=x`. AFAIK it's a regression after#23296, but it's the first time i noticed so maybe it's related to a chrome change in between. No real CSS expert.. but this seems to fix it.Before:After:I can confirm both chrome and firefox render as shown in the after screenshot. Firefox worked before as well, chrome not.cc@ogizanagiCommits-------ee45992 [WebProfilerBundle] Fix anchor CSS
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The css trick used was incomplete (missing
display: block;), which is probably why it has been changed inhttps://github.com/symfony/symfony/pull/22455/files#diff-7d417267ae50374356ab990c58233a9bR67.Despite the current version works well, it behaves quite ugly specifically on Chrome:
For ref about the trick:https://stackoverflow.com/questions/10732690/offsetting-an-html-anchor-to-adjust-for-fixed-header/13184714#13184714