Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Show exception is checked twice in ExceptionController of twig#23268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
fabpot commentedJun 22, 2017
Thank you@gmponos. |
…twig (gmponos)This PR was submitted for the 3.4 branch but it was merged into the 2.7 branch instead (closes#23268).Discussion----------Show exception is checked twice in ExceptionController of twig| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | no| New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files -->| BC breaks? | no| Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR | N/AI think that the $showException variable is checked twice. Check line 105 of the same file. Hope I did not miss anythings since the tests are passing.Commits-------a433cec Show exception is checked twice in ExceptionController of twig
xabbuh commentedJun 24, 2017
I think the check is still needed for the case when |
gmponos commentedJun 24, 2017
👊 You are right. There should have been a test for this. Good thing you added it. Maybe this |
This PR was merged into the 2.7 branch.Discussion----------[TwigBundle] add back exception check| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#23268| License | MIT| Doc PR |#23268 introduced a regression in that the full exception page was not shown anymore in case a template for the given format (if not `html`) could not be found.Commits-------46c38df [TwigBundle] add back exception check
I think that the $showException variable is checked twice. Check line 105 of the same file. Hope I did not miss anythings since the tests are passing.