Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DI] Dedup tags when using instanceof/autoconfigure#23218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Taking attributes into account while deduplicating is a requirement. Compiler passes have to be able to behave correctly when duplicates are found, we reviewed SF ones while doing 3.3, they are all good.
This means this is not really a bug fix, because the only practical side effect is the output of descriptors, which was just... descriptive :)
But since I can't find any use case for non deduplicated tagswith same attributes, I'm 👍
weaverryan left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Hmm, ok - makes sense to me and I can't think of an issue with this.
fabpot commentedJun 20, 2017
Thank you@ogizanagi. |
…nagi)This PR was merged into the 3.3 branch.Discussion----------[DI] Dedup tags when using instanceof/autoconfigure| Q | A| ------------- | ---| Branch? | 3.3 <!-- see comment below -->| Bug fix? | yes| New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files -->| BC breaks? | no| Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->| Tests pass? | yes, failures unrelated (8dc00bb)| Fixed tickets | N/A <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR | N/AThis fixes uselessly duplicated tags shown when using the `debug:container` command, or in the dumped container in xml format:<img width="554" alt="screenshot 2017-06-17 a 20 41 27" src="https://user-images.githubusercontent.com/2211145/27255375-de79fc4e-539d-11e7-98d9-c10074ddcffb.PNG"><img width="494" alt="screenshot 2017-06-17 a 20 41 54" src="https://user-images.githubusercontent.com/2211145/27255376-de7ff5b8-539d-11e7-97ae-ccd31b1d5254.PNG"><img width="1371" alt="screenshot 2017-06-17 a 20 42 33" src="https://user-images.githubusercontent.com/2211145/27255377-de869ba2-539d-11e7-8cd7-6005f8a499d6.PNG">(duplicates here are explained by the twig namespaced and unnamespaced versions, and the controllers being tagged explicitly inhttps://github.com/symfony/symfony-demo/blob/master/app/config/services.yml#L25, while also being tagged by autoconfiguration ([which is expected](symfony/symfony-docs#7921 (comment))))Commits-------9f877ef [DI] Dedup tags when using instanceof/autoconfigure
Uh oh!
There was an error while loading.Please reload this page.
This fixes uselessly duplicated tags shown when using the
debug:containercommand, or in the dumped container in xml format:(duplicates here are explained by the twig namespaced and unnamespaced versions, and the controllers being tagged explicitly inhttps://github.com/symfony/symfony-demo/blob/master/app/config/services.yml#L25, while also being tagged by autoconfiguration (which is expected))