Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Config] Fix ** GlobResource on Windows#23168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
+12 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
6bda975 to58b152fCompareMember
stof commentedJun 14, 2017
why can't we tell it to use unix paths ? |
MemberAuthor
nicolas-grekas commentedJun 14, 2017
because Finder doesn't have any mean to inject that flag, or did I miss it? |
Member
stof commentedJun 14, 2017
hmm, indeed. |
stof approved these changesJun 14, 2017
fabpot approved these changesJun 14, 2017
Member
fabpot commentedJun 14, 2017
Thank you@nicolas-grekas. |
fabpot added a commit that referenced this pull requestJun 14, 2017
This PR was merged into the 3.3 branch.Discussion----------[Config] Fix ** GlobResource on Windows| Q | A| ------------- | ---| Branch? | 3.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#23103| License | MIT| Doc PR | -We cannot tell Finder to use RecursiveDirectoryIterator::UNIX_PATHS so we have to fix paths on Windows.Commits-------44955be [Config] Fix ** GlobResource on Windows
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We cannot tell Finder to use RecursiveDirectoryIterator::UNIX_PATHS so we have to fix paths on Windows.