Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[PropertyAccess] Fix Usage with anonymous classes#23156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
c071743 to5a5a08bCompare| publicfunctiontestAnonymousClassRead() | ||
| { | ||
| if (PHP_MAJOR_VERSION <7) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
use@requires php 7 annotation instead (same below)
| } | ||
| /** | ||
| * @param $value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
should be removed
Replace forbidden characters in the the class names of Anonymous Classes in form of"class@anonymous /symfony/src/Symfony/Component/PropertyAccess/Tests/PropertyAccessorTest.php0x7f3f5f267ad5"Wrapped in eval to avoid PHP parsing errors < 7
5a5a08b to3f7fd43Compare
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
fabpot commentedJun 14, 2017
Thank you@mablae. |
This PR was merged into the 3.2 branch.Discussion----------[PropertyAccess] Fix Usage with anonymous classes| Q | A| ------------- | ---| Branch? | 3.2| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#23136| License | MITReplace forbidden characters in the the class names of Anonymous Classes in form of"class@anonymous /symfony/src/Symfony/Component/PropertyAccess/Tests/PropertyAccessorTest.php0x7f3f5f267ad5"Wrapped in eval to avoid PHP parsing errors < 7 and using `rawurlenceode` for perf reasonsThanks@nicolas-grekas for the help and patience. Let me know if anything is missing.Commits-------3f7fd43 Fix Usage with anonymous classes
Uh oh!
There was an error while loading.Please reload this page.
Replace forbidden characters in the the class names of Anonymous Classes in form of
"class@anonymous /symfony/src/Symfony/Component/PropertyAccess/Tests/PropertyAccessorTest.php0x7f3f5f267ad5"
Wrapped in eval to avoid PHP parsing errors < 7 and using
rawurlenceodefor perf reasonsThanks@nicolas-grekas for the help and patience. Let me know if anything is missing.