Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DI] Fix keys resolution in ResolveParameterPlaceHoldersPass#23141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
The head ref may contain hidden characters:"\u00B5optim"
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| $value->setProperties($this->bag->resolveValue($value->getProperties())); | ||
| $value->setMethodCalls($this->bag->resolveValue($value->getMethodCalls())); | ||
| } | ||
| if (is_array($value =parent::processValue($value,$isRoot)) &&$value) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I would move the parent call outside the if, to be more clear (and remove potential mistakes where deciding to remove the handling of keys might also remove the parent call while it is always necessary)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
done
fabpot commentedJun 12, 2017
Thank you@nicolas-grekas. |
…ss (nicolas-grekas)This PR was merged into the 3.3 branch.Discussion----------[DI] Fix keys resolution in ResolveParameterPlaceHoldersPass| Q | A| ------------- | ---| Branch? | 3.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -Keys are resolved in 3.2, but we broke that when moving to AbstractRecursivePass.Commits-------9251a21 [DI] Fix keys resolution in ResolveParameterPlaceHoldersPass
Keys are resolved in 3.2, but we broke that when moving to AbstractRecursivePass.