Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Yaml] Remove line number in deprecation notices#23108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
stof commentedJun 8, 2017
👍 |
| throw$e; | ||
| } | ||
| if (!(Yaml::PARSE_KEYS_AS_STRINGS &$flags) && !is_string($key)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
integer keys must be allowed, not only string keys (PHP array support integers). Can you also fix it (there is a PR fixing it currently, but together with other changes and so targetting 3.4)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
like that?
fabpot commentedJun 9, 2017
Thank you@nicolas-grekas. |
…grekas)This PR was merged into the 3.3 branch.Discussion----------[Yaml] Remove line number in deprecation notices| Q | A| ------------- | ---| Branch? | 3.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -While moving an app to 3.3, I noticed that my deprecation log is full of deprecation notices that differ only by some line number, but don't tell which file is concerned.This makes the line number useless, and just prevents aggregation.Commits-------f82b618 [Yaml] Remove line number in deprecation notices
rvanlaak commentedJun 12, 2017
Although I 👍 with the MR, I think the line numbers would be really helpful. Maybe in a more verbose |
stof commentedJun 12, 2017
@rvanlaak |
nicolas-grekas commentedJun 12, 2017
An without the file, line numbers are useless... |
…ecation (xabbuh)This PR was merged into the 3.3 branch.Discussion----------[DependencyInjection] include file and line number in deprecation| Q | A| ------------- | ---| Branch? | 3.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |In#23108 we removed line numbers from deprecation messages created by the YAML parser because those numbers were quite useless without the file being parsed. I suggest to revert this change and add the file being parsed to the deprecation message.Commits-------cf03552 include file and line number in deprecation
Uh oh!
There was an error while loading.Please reload this page.
While moving an app to 3.3, I noticed that my deprecation log is full of deprecation notices that differ only by some line number, but don't tell which file is concerned.
This makes the line number useless, and just prevents aggregation.