Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Cache] ApcuAdapter::isSupported() should return true when apc.enable_cli=Off#23091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| if ($allowCompile) { | ||
| @opcache_compile_file($file); | ||
| @opcache_invalidate($file,true); |
nicolas-grekasJun 8, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Just verified with@jpauli:opcache_compile_file does not invalidate. Let's call onlyopcache_invalidate.
| protectedfunctiondoClear($namespace) | ||
| { | ||
| returnisset($namespace[0]) &&class_exists('APCuIterator',false) | ||
| returnisset($namespace[0]) &&class_exists('APCuIterator',false) && ('cli' !==PHP_SAPI ||ini_get('apc.enable_cli')) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
new APCuIterator triggers a fatal error when apcu is not enabled...
fabpot commentedJun 9, 2017
Thank you@nicolas-grekas. |
… apc.enable_cli=Off (nicolas-grekas)This PR was merged into the 3.2 branch.Discussion----------[Cache] ApcuAdapter::isSupported() should return true when apc.enable_cli=Off| Q | A| ------------- | ---| Branch? | 3.2| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -By being sensitive to apc.enable_cli, CLI cache warmup is broken when the setting is set to off because a PhpFilesAdapter will be warmed up by the CLI, whereas the Web mode will look at the FilesystemAdapter pools, which will be empty.Commits-------aadf263 [Cache] APCu isSupported() should return true when apc.enable_cli=Off
Uh oh!
There was an error while loading.Please reload this page.
By being sensitive to apc.enable_cli, CLI cache warmup is broken when the setting is set to off because a PhpFilesAdapter will be warmed up by the CLI, whereas the Web mode will look at the FilesystemAdapter pools, which will be empty.