Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[SecurityBundle] Made 2 service aliases private#23090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Hanmac commentedJun 7, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
i don't like it to make |
nicolas-grekas commentedJun 7, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@Hanmac this is making |
stof commentedJun 7, 2017
I'm 👍 for this, as we never documented these aliases (they are there for autowiring purpose only) |
fabpot commentedJun 9, 2017
Thank you@nicolas-grekas. |
…rekas)This PR was merged into the 3.3 branch.Discussion----------[SecurityBundle] Made 2 service aliases private| Q | A| ------------- | ---| Branch? | 3.3| Bug fix? | yes| New feature? | no| BC breaks? | yes| Deprecations? | no| Tests pass? | no| Fixed tickets | -| License | MIT| Doc PR | -We missed making them private :(Is it too late to fix that?Commits-------4442c63 [SecurityBundle] Made 2 service aliases private
We missed making them private :(
Is it too late to fix that?