Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[SecurityBundle] Made 2 service aliases private#23090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:3.3fromnicolas-grekas:priv-alias
Jun 9, 2017

Conversation

@nicolas-grekas
Copy link
Member

QA
Branch?3.3
Bug fix?yes
New feature?no
BC breaks?yes
Deprecations?no
Tests pass?no
Fixed tickets-
LicenseMIT
Doc PR-

We missed making them private :(
Is it too late to fix that?

sstok, jvasseur, and Hanmac reacted with thumbs up emoji
@Hanmac
Copy link
Contributor

Hanmac commentedJun 7, 2017
edited
Loading

i don't like it to makesecurity.authorization_checker private.
i have many bundles in my projects (like Sonata, or Sensio) which does use this service for theisGranted check. what else should be used for that?

@nicolas-grekas
Copy link
MemberAuthor

nicolas-grekas commentedJun 7, 2017
edited
Loading

@Hanmac this is making
Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface
and
Symfony\Component\Security\Core\Encoder\UserPasswordEncoderInterface
private,
it doesn't change anything when usingsecurity.authorization_checker.

@stof
Copy link
Member

stof commentedJun 7, 2017

I'm 👍 for this, as we never documented these aliases (they are there for autowiring purpose only)

@fabpot
Copy link
Member

Thank you@nicolas-grekas.

@fabpotfabpot merged commit4442c63 intosymfony:3.3Jun 9, 2017
fabpot added a commit that referenced this pull requestJun 9, 2017
…rekas)This PR was merged into the 3.3 branch.Discussion----------[SecurityBundle] Made 2 service aliases private| Q             | A| ------------- | ---| Branch?       | 3.3| Bug fix?      | yes| New feature?  | no| BC breaks?    | yes| Deprecations? | no| Tests pass?   | no| Fixed tickets | -| License       | MIT| Doc PR        | -We missed making them private :(Is it too late to fix that?Commits-------4442c63 [SecurityBundle] Made 2 service aliases private
@fabpotfabpot mentioned this pull requestJul 4, 2017
@nicolas-grekasnicolas-grekas deleted the priv-alias branchJuly 10, 2017 15:58
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@xabbuhxabbuhxabbuh approved these changes

@chalasrchalasrchalasr approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

3.3

Development

Successfully merging this pull request may close these issues.

7 participants

@nicolas-grekas@Hanmac@stof@fabpot@xabbuh@chalasr@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp