Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] Fix perf issue in CacheClearCommand::warmup()#23086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Wirone commentedJun 7, 2017
This PR is related to my specific case where upgrading to 3.3 in one of our apps makes it unusable in @nicolas-grekas can view those profiles. |
Wirone commentedJun 7, 2017
Without additional |
fabpot commentedJun 9, 2017
Thank you@nicolas-grekas. |
…mup() (nicolas-grekas)This PR was merged into the 2.7 branch.Discussion----------[FrameworkBundle] Fix perf issue in CacheClearCommand::warmup()| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -On slow file systems (eg on Windows), I noticed that writing files without doing any changes just kills perf.Limiting the depth also helps when the symfony/cache component is used (because it can store thousands of files in its cache pool directory structure, and iterating there is also a waste of *fs* time).I choose the max depth by looking at where existing apps put their files and added one level more just in case.Commits-------b58f060 [FrameworkBundle] Fix perf issue in CacheClearCommand::warmup()
Uh oh!
There was an error while loading.Please reload this page.
On slow file systems (eg on Windows), I noticed that writing files without doing any changes just kills perf.
Limiting the depth also helps when the symfony/cache component is used (because it can store thousands of files in its cache pool directory structure, and iterating there is also a waste offs time).
I choose the max depth by looking at where existing apps put their files and added one level more just in case.