Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Config] Always protected ClassExistenceResource against bad parents#23041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
MemberAuthor
nicolas-grekas commentedJun 2, 2017
Related tosymfony/recipes#91 (missing parent should not make the container compilation fail) |
fabpot approved these changesJun 2, 2017
MemberAuthor
nicolas-grekas commentedJun 2, 2017
Appveyor failure is from a transient test. |
Member
fabpot commentedJun 2, 2017
Thank you@nicolas-grekas. |
fabpot added a commit that referenced this pull requestJun 2, 2017
…ad parents (nicolas-grekas)This PR was merged into the 3.3 branch.Discussion----------[Config] Always protected ClassExistenceResource against bad parents| Q | A| ------------- | ---| Branch? | 3.3| Bug fix? | yes| New feature? | no| BC breaks? | (new hidden feat)| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -Let's always protected against bad or missing parents. The protection was conditional because the protection adds some perf overhead, but this was a micro optim really...BC break is for a new feat, better not maintain this.Commits-------86bf26c [Config] Always protect ClassExistenceResource against bad parents
Merged
fabpot added a commit that referenced this pull requestJul 19, 2017
…nts (nicolas-grekas)This PR was merged into the 3.3 branch.Discussion----------[Config] Make ClassExistenceResource throw on invalid parents| Q | A| ------------- | ---| Branch? | 3.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#23564| License | MIT| Doc PR | -Let's throw a more specific exception when a parent class/interface/trait is missing.Fine tunes#23041Commits-------53b0190 [Config] Make ClassExistenceResource throw on invalid parents
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's always protected against bad or missing parents. The protection was conditional because the protection adds some perf overhead, but this was a micro optim really...
BC break is for a new feat, better not maintain this.