Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] Fix CacheCollectorPass priority#23018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
55b776c to432072cComparetifabien commentedJun 1, 2017
@chalasr I just tested your PR in my project and it seems it solves my issue :) Should I have a short explanation of what was the problem? Thanks a lot! |
chalasr commentedJun 1, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@tifabien The You're welcome, thanks for confirming. |
| <!-- DataCollector--> | ||
| <serviceid="data_collector.cache"class="Symfony\Component\Cache\DataCollector\CacheDataCollector"> | ||
| <!-- DataCollector(must be public to prevent inlining)--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
public to prevent inlining, made private in Cache...Pass
432072c toa347ae3Comparea347ae3 to28b253aCompare
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
fabpot commentedJun 1, 2017
Thank you@chalasr. |
This PR was merged into the 3.3 branch.Discussion----------[FrameworkBundle] Fix CacheCollectorPass priority| Q | A| ------------- | ---| Branch? | 3.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |#22960 (comment)It was run before optimization, so child definitions were not resolved yet.Commits-------28b253a Fix CacheCollectorPass priority
It was run before optimization, so child definitions were not resolved yet.