Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[FrameworkBundle] Fix CacheCollectorPass priority#23018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:3.3fromchalasr:cache_collector_priority
Jun 1, 2017

Conversation

@chalasr
Copy link
Member

QA
Branch?3.3
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets
LicenseMIT
Doc PR#22960 (comment)

It was run before optimization, so child definitions were not resolved yet.

@tifabien
Copy link
Contributor

@chalasr I just tested your PR in my project and it seems it solves my issue :) Should I have a short explanation of what was the problem?

Thanks a lot!

@chalasr
Copy link
MemberAuthor

chalasr commentedJun 1, 2017
edited
Loading

@tifabien Thecache.app serviceextends thecache.adapter.filesystem one.
There isa compiler pass responsible for completing all services which extend another (merging from the parent). This pass processes the container in its optimization phase.
On the other hand, there is a compiler pass responsible for decorating allcache.pool tagged services to make them "traceable" and for injecting them into the data collector. Given this pass was processing the container before its optimization phase, child services weren't complete yet (hence the missing class). This makes it run after optimization, so the data collector pass can rely on the class even for services which inherit it from their parent.

You're welcome, thanks for confirming.


<!-- DataCollector-->
<serviceid="data_collector.cache"class="Symfony\Component\Cache\DataCollector\CacheDataCollector">
<!-- DataCollector(must be public to prevent inlining)-->

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

public to prevent inlining, made private in Cache...Pass

@chalasrchalasrforce-pushed thecache_collector_priority branch from432072c toa347ae3CompareJune 1, 2017 17:00
@chalasrchalasrforce-pushed thecache_collector_priority branch froma347ae3 to28b253aCompareJune 1, 2017 17:06
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

@nicolas-grekasnicolas-grekas added this to the3.3 milestoneJun 1, 2017
@fabpot
Copy link
Member

Thank you@chalasr.

@fabpotfabpot merged commit28b253a intosymfony:3.3Jun 1, 2017
fabpot added a commit that referenced this pull requestJun 1, 2017
This PR was merged into the 3.3 branch.Discussion----------[FrameworkBundle] Fix CacheCollectorPass priority| Q             | A| ------------- | ---| Branch?       | 3.3| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        |#22960 (comment)It was run before optimization, so child definitions were not resolved yet.Commits-------28b253a Fix CacheCollectorPass priority
@chalasrchalasr deleted the cache_collector_priority branchJune 1, 2017 18:39
@fabpotfabpot mentioned this pull requestJun 5, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

3.3

Development

Successfully merging this pull request may close these issues.

5 participants

@chalasr@tifabien@fabpot@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp