Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[DI] Autowiring exception thrown when inlined service is removed#22993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

@weaverryan
Copy link
Member

@weaverryanweaverryan commentedMay 31, 2017•
edited
Loading

QA
Branch?3.3
Bug fix?yes
New feature?no
BC breaks?yes
Deprecations?yes (on a new & internal method)
Tests pass?yes
Fixed tickets#22977
LicenseMIT
Doc PRn/a

We suppress autowiring exceptions if a service is ultimately removed from the container. This fixes a bug where we incorrectly report that a service was NOT removed, when really, it WAS removed. This happens whenServiceA is inlined inServiceB... but thenServiceB is removed from the container for being unused.

@weaverryanweaverryanforce-pushed thefix-inline-unused-classes branch from3375e6b todd82f76CompareMay 31, 2017 14:36
@weaverryan
Copy link
MemberAuthor

Second commit actually removes thegetInlinedServiceIds() method. This has only existed since 3.3.0 - so it's a BC break, but is highly unlikely to be used. I'm fine with keeping it (deprecated) or removing it.

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍 (including the "BC break" with .0 nobody can possibly rely on this already, and even if, that'd be fresh code, easy to update)

@nicolas-grekasnicolas-grekas added this to the3.3 milestoneMay 31, 2017
@fabpot
Copy link
Member

Thank you@weaverryan.

samsch reacted with thumbs up emoji

fabpot added a commit that referenced this pull requestMay 31, 2017
…emoved (weaverryan)This PR was squashed before being merged into the 3.3 branch (closes#22993).Discussion----------[DI] Autowiring exception thrown when inlined service is removed| Q             | A| ------------- | ---| Branch?       | 3.3| Bug fix?      | yes| New feature?  | no| BC breaks?    | yes| Deprecations? | yes (on a new & internal method)| Tests pass?   | yes| Fixed tickets |#22977| License       | MIT| Doc PR        | n/aWe suppress autowiring exceptions if a service is ultimately removed from the container. This fixes a bug where we incorrectly report that a service was NOT removed, when really, it WAS removed. This happens when `ServiceA` is inlined in `ServiceB`... but then `ServiceB` is removed from the container for being unused.Commits-------793b9a0 [DI] Autowiring exception thrown when inlined service is removed
@fabpotfabpot closed thisMay 31, 2017
@weaverryanweaverryan deleted the fix-inline-unused-classes branchMay 31, 2017 18:48
@fabpotfabpot mentioned this pull requestJun 5, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@stofstofstof approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

3.3

Development

Successfully merging this pull request may close these issues.

5 participants

@weaverryan@fabpot@nicolas-grekas@stof@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp