Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Config] Allow empty globs#22985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
* 3.3: [Config] Fallback to regular import when glob fails
sstok commentedMay 31, 2017
How would this look like for |
nicolas-grekas commentedMay 31, 2017
you can run the code to know ;) |
fabpot commentedMay 31, 2017
Thank you@nicolas-grekas. |
This PR was merged into the 3.3 branch.Discussion----------[Config] Allow empty globs| Q | A| ------------- | ---| Branch? | 3.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#22950| License | MIT| Doc PR | -This considers globs as valid even if they return no matches when they have a prefix (and when that prefix exists, according to `$ignoreErrors`).This means there is an edge-case:`*.abc` with at least one match is OK, but when it has no match, it falls back to regular import, then usually will fil.But rewriting this to `./*.abc` resolves the ambiguity and turns this into a glob that won't fail if no matches are found.This should provide the expected behavior in most cases (but ambiguous described one of course).Commits-------c5b9c1a [Config] Allow empty globs
Majkl578 commentedJun 1, 2017
@nicolas-grekas Thanks, this definitely makes more sense for Flex-based apps (using glob patterns). 👍 |
This considers globs as valid even if they return no matches when they have a prefix (and when that prefix exists, according to
$ignoreErrors).This means there is an edge-case:
*.abcwith at least one match is OK, but when it has no match, it falls back to regular import, then usually will fil.But rewriting this to
./*.abcresolves the ambiguity and turns this into a glob that won't fail if no matches are found.This should provide the expected behavior in most cases (but ambiguous described one of course).