Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Profiler] Fix code excerpt wrapping#22971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
yceruto commentedMay 30, 2017
👍 to never wrap! it feels less messy (to me too) |
ro0NL commentedMay 30, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Looking at it, i think the line-height really needs a patch as well (part of discussion in#22439, but perhaps we can do it here already). The space between |
ogizanagi commentedMay 30, 2017
nicolas-grekas commentedJun 2, 2017
I like how github does. Wrapping code is a bad idea I think. |
ogizanagi commentedJun 2, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Great! So it seems we have a consensus about this currently (at least no opponent right now). Either I update this PR to always prevent wrapping and allow horizontal scrolling with minimal changes, either we reconsider#22439 to target 3.3 as a bug fix and we close this one. |
nicolas-grekas commentedJun 2, 2017
if it's a few css lines+classes, let's do that - it wouldn't prevent considering#22439 afterwards |
ogizanagi commentedJun 3, 2017
Done.
(I also slightly updated the line height, so it feels more natural and consistant for every lines. Poke@ro0NL) |
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
ro0NL commentedJun 3, 2017
Much better 👍 |
fabpot commentedJun 3, 2017
Thank you@ogizanagi. |
This PR was merged into the 3.3 branch.Discussion----------[Profiler] Fix code excerpt wrapping| Q | A| ------------- | ---| Branch? | 3.3 <!-- see comment below -->| Bug fix? | yesish| New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files -->| BC breaks? | no| Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->| Tests pass? | yes| Fixed tickets | N/A <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR | N/A|Before|After||--|--||<img width="1346" alt="screenshot 2017-05-30 a 19 09 03" src="https://cloud.githubusercontent.com/assets/2211145/26595449/b8c4302c-456b-11e7-83c4-3471f915437b.PNG">|<img width="1075" alt="screenshot 2017-05-30 a 19 09 35" src="https://cloud.githubusercontent.com/assets/2211145/26595450/b8c61e64-456b-11e7-8b33-bdbe2e90b160.PNG">|However, I think my own preference for code excerpts would be to never wrap, at the risk of scrolling horizontally. 1024px is enough to read most of the code excerpt without scrolling, and it feels less messy (to me) when a line is too long. WDYT?Commits-------6c87863 [Profiler] Never wrap in code excerpts


However, I think my own preference for code excerpts would be to never wrap, at the risk of scrolling horizontally. 1024px is enough to read most of the code excerpt without scrolling, and it feels less messy (to me) when a line is too long. WDYT?