Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Profiler] Fix code excerpt wrapping#22971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:3.3fromogizanagi:fix/profiler/code_wrap
Jun 3, 2017
Merged

[Profiler] Fix code excerpt wrapping#22971

fabpot merged 1 commit intosymfony:3.3fromogizanagi:fix/profiler/code_wrap
Jun 3, 2017

Conversation

@ogizanagi
Copy link
Contributor

QA
Branch?3.3
Bug fix?yesish
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed ticketsN/A
LicenseMIT
Doc PRN/A
BeforeAfter
screenshot 2017-05-30 a 19 09 03screenshot 2017-05-30 a 19 09 35

However, I think my own preference for code excerpts would be to never wrap, at the risk of scrolling horizontally. 1024px is enough to read most of the code excerpt without scrolling, and it feels less messy (to me) when a line is too long. WDYT?

yceruto and ro0NL reacted with thumbs up emoji
@yceruto
Copy link
Member

👍 to never wrap! it feels less messy (to me too)

jvasseur reacted with thumbs up emoji

@ro0NL
Copy link
Contributor

ro0NL commentedMay 30, 2017
edited
Loading

Looking at it, i think the line-height really needs a patch as well (part of discussion in#22439, but perhaps we can do it here already). The space between} andthrow intuitively looks like 2 line breaks (based on the font size).

@ogizanagi
Copy link
ContributorAuthor

Hmmm. I guess we can close this one if we can accept#22439 as a "bug fix".
Or we can merge this one instead, just fixing the code wrapping and keep the nowrap suggestion for 3.4 in#22439, but I guess it'd be better to have something consistent between 3.3 and 3.4 about this...

@nicolas-grekas
Copy link
Member

I like how github does. Wrapping code is a bad idea I think.

yceruto and ogizanagi reacted with thumbs up emoji

@ogizanagi
Copy link
ContributorAuthor

ogizanagi commentedJun 2, 2017
edited
Loading

Great! So it seems we have a consensus about this currently (at least no opponent right now).

Either I update this PR to always prevent wrapping and allow horizontal scrolling with minimal changes, either we reconsider#22439 to target 3.3 as a bug fix and we close this one.
IMHO, I'd love to see#22439 merged in 3.3, because (despite I didn't check it out yet), it seems@sustmi did great and it's not DX but UI/UX fixes to me. Also, I clearly think having 2 different UI/UX on 3.3 and 3.4+ will only complicate maintenance.

@nicolas-grekas
Copy link
Member

prevent wrapping and allow horizontal scrolling with minimal changes

if it's a few css lines+classes, let's do that - it wouldn't prevent considering#22439 afterwards

@ogizanagi
Copy link
ContributorAuthor

Done.

BeforeAfter
juin-03-2017 10-38-47juin-03-2017 10-39-04

(I also slightly updated the line height, so it feels more natural and consistant for every lines. Poke@ro0NL)

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

@ro0NL
Copy link
Contributor

Much better 👍

@fabpot
Copy link
Member

Thank you@ogizanagi.

@fabpotfabpot merged commit6c87863 intosymfony:3.3Jun 3, 2017
fabpot added a commit that referenced this pull requestJun 3, 2017
This PR was merged into the 3.3 branch.Discussion----------[Profiler] Fix code excerpt wrapping| Q             | A| ------------- | ---| Branch?       | 3.3 <!-- see comment below -->| Bug fix?      | yesish| New feature?  | no <!-- don't forget updating src/**/CHANGELOG.md files -->| BC breaks?    | no| Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->| Tests pass?   | yes| Fixed tickets | N/A <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | N/A|Before|After||--|--||<img width="1346" alt="screenshot 2017-05-30 a 19 09 03" src="https://cloud.githubusercontent.com/assets/2211145/26595449/b8c4302c-456b-11e7-83c4-3471f915437b.PNG">|<img width="1075" alt="screenshot 2017-05-30 a 19 09 35" src="https://cloud.githubusercontent.com/assets/2211145/26595450/b8c61e64-456b-11e7-8b33-bdbe2e90b160.PNG">|However, I think my own preference for code excerpts would be to never wrap, at the risk of scrolling horizontally. 1024px is enough to read most of the code excerpt without scrolling, and it feels less messy (to me) when a line is too long. WDYT?Commits-------6c87863 [Profiler] Never wrap in code excerpts
@ogizanagiogizanagi deleted the fix/profiler/code_wrap branchJune 3, 2017 15:57
@fabpotfabpot mentioned this pull requestJun 5, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

3.3

Development

Successfully merging this pull request may close these issues.

6 participants

@ogizanagi@yceruto@ro0NL@nicolas-grekas@fabpot@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp