Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Cache] Ignore missing annotations.php#22965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedMay 30, 2017
In 3.2 we use file_exists, this somehow got lost in a merge I guess |
ro0NL commentedMay 30, 2017
you refactored in#20694 :) from the looks of it i'd say stream_resolve_include_path + include without @ but im not sure that needs to be supported or so; otherwise file_exists/is_file will do. Note 3.2 doesnt use @ |
nicolas-grekas commentedMay 30, 2017
let's do the same as in 3.2, that's fine |
ro0NL commentedMay 31, 2017
This should do. |
fabpot commentedMay 31, 2017
Thank you@ro0NL. |
This PR was squashed before being merged into the 3.3 branch (closes#22965).Discussion----------[Cache] Ignore missing annotations.php| Q | A| ------------- | ---| Branch? | 3.3| Bug fix? | yes (different in 3.2)| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR | symfony/symfony-docs#... <!--highly recommended for new features-->Avoids the following notices if cache is not warmed up (i.e. `cache:clear --no-warmup` > hit the browser).```Warning: include(<base-path>/app/cache/<env>/annotations.php): failed to open stream: No such file or directoryWarning: include(): Failed opening '<base-path>/app/cache/<env>/annotations.php' for inclusion (include_path='.:/usr/share/pear:/usr/share/php')```Commits-------e8f70c7 [Cache] Ignore missing annotations.php
Uh oh!
There was an error while loading.Please reload this page.
Avoids the following notices if cache is not warmed up (i.e.
cache:clear --no-warmup> hit the browser).