Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Config] Fallback to regular import when glob fails#22940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| }else { | ||
| foreach ($this->glob($resource,false,$_,$ignoreErrors)as$path =>$info) { | ||
| ++$ct; | ||
| if (is_string($resource) &&false !==strpbrk($resource,'*?{[')) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
(...) || $type === 'glob' right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
not sure it would change anything, so not to me
fabpot commentedMay 29, 2017
Thank you@nicolas-grekas. |
…as-grekas)This PR was merged into the 4.0-dev branch.Discussion----------[Config] Fallback to regular import when glob fails| Q | A| ------------- | ---| Branch? | 3.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#22938| License | MIT| Doc PR | -Fixes a BC break as reported in linked issue.Commits-------29802a2 [Config] Fallback to regular import when glob fails
fabpot commentedMay 29, 2017
Thank you@nicolas-grekas. |
…as-grekas)This PR was submitted for the master branch but it was merged into the 3.3 branch instead (closes#22940).Discussion----------[Config] Fallback to regular import when glob fails| Q | A| ------------- | ---| Branch? | 3.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#22938| License | MIT| Doc PR | -Fixes a BC break as reported in linked issue.Commits-------7b4066e [Config] Fallback to regular import when glob fails
Majkl578 commentedMay 29, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This has broken my app while upgrading from 3.3.0-RC1 to 3.3.0. 😞 Kernel::configureRoutes() +- same as inthe Flex recipe, |
nicolas-grekas commentedMay 29, 2017
Please open an issue with a description of the conditions + reproducer if possible |
Majkl578 commentedMay 29, 2017
Here you go:#22950 |
Fixes a BC break as reported in linked issue.