I am not sure if it is a good idea to apply this "globally". For theattr option, doing a recursive merge does work. But this may not be the case for all other options where the usage of some keys may be mutually exclusive.

What we can do: First merge all guess options recursively and then do the merge here as before.

But this may not be the case for all other options where the usage of some keys may be mutually exclusive.

Sorry :/ I don't see what I missing here, would you show me an example, please? I've done a simple test (https://3v4l.org/5FvnM) but I don't see what is wrong witharray_replace_recursive() function :/

seehttps://3v4l.org/JOK0d

We don't know if it is allowed to use both keysbaz andbar at the same time for thefoo option.

I suggest to change the code as follows:

$guessedOptions =array();if (null !==$pattern) {$guessedOptions =array_replace_recursive(array('attr' =>array('pattern' =>$pattern)),$guessedOptions);}if (null !==$maxLength) {$guessedOptions =array_replace_recursive(array('attr' =>array('maxlength' =>$maxLength)),$guessedOptions);}if ($requiredGuess) {$guessedOptions =array_merge(array('required' =>$requiredGuess->getValue()),$guessedOptions);}if ($typeGuess) {$guessedOptions =array_replace_recursive($typeGuess->getOptions(),$guessedOptions);}// user options may override guessed options$options =array_merge($guessedOptions,$options);

Following the first assumption:

But this may not be the case for all other options where the usage of some keys may be mutually exclusive.

Still we can passfalse to the user option and it not will be displayed, i.e.:

$form->add('foo',null,array('foo' =>array('baz' =>false,'bar' =>'foobar')));//...$customGuessedOptions =array('foo' =>array('baz' =>'foobaz'));

My comment above should have usedarray_replace_recursive() for the type guess too (I updated it).

Losing themaxlength attribute when passing theattr option is expected IMO as you opted to be more clever than the guessers for theattr option.

Losing the maxlength attribute when passing the attr option is expected IMO [...]

It's not a BC break? before this PR it's not true and the issue description proposes mixattr options also between guessed options and populated options, so now the one that is lost is me :)

Losing the maxlength attribute when passing the attr option is expected

It should not as it could trigger an unwanted deprecation.