Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Filesystem] improve error handling in lock()#22910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedMay 25, 2017
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #22882 |
| License | MIT |
| Doc PR |
| } | ||
| if (!$einstanceof IOException) { | ||
| $this->fail(sprintf('Expected IOException to be thrown, got %s instead.',get_class($e))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
is this required if we remove the two last "catch"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
hum ok, for cleanup
| $this->fail(sprintf('Expected IOException to be thrown, got %s instead.',get_class($e))); | ||
| } | ||
| if (null !==$wrongMessage) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
assertNull?
| if (!$this->handle) { | ||
| $error =error_get_last(); | ||
| thrownewIOException($error['message'],0,null,$this->file); | ||
| if (null ===$error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
is this possible at all? to me it shouldn't
nicolas-grekas commentedMay 28, 2017
Thank you@xabbuh. |
This PR was merged into the 2.7 branch.Discussion----------[Filesystem] improve error handling in lock()| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#22882| License | MIT| Doc PR |Commits-------25381a2 [Filesystem] improve error handling in lock()