Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[FrameworkBundle][Validator] Move the PSR-11 factory to the component#22905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
stof merged 1 commit intosymfony:3.3fromogizanagi:mv_container_cons_validator_factory
May 26, 2017
Merged

[FrameworkBundle][Validator] Move the PSR-11 factory to the component#22905

stof merged 1 commit intosymfony:3.3fromogizanagi:mv_container_cons_validator_factory
May 26, 2017

Conversation

@ogizanagi
Copy link
Contributor

QA
Branch?3.3
Bug fix?no
New feature?no
BC breaks?no
Deprecations?yes
Tests pass?yes
Fixed tickets#22887 (comment)
LicenseMIT
Doc PRN/A

Instead of the 3 following deprecations:

  • TheConstraintValidatorFactory::$validators and$container properties
    have been deprecated and will be removed in 4.0.
  • ExtendingConstraintValidatorFactory is deprecated and won't be supported in 4.0.
  • Passing an array of validators or validator aliases as the second argument of
    ConstraintValidatorFactory::__construct() is deprecated since 3.3 and will
    be removed in 4.0. Use the service locator instead.

I'd suggest simply deprecating the FrameworkBundle's class in favor of using a newContainerConstraintValidatorFactory. To me, there is no reason anyone using the validator component without the framework bundle cannot use this PSR-11 compliant implementation, nor I see a reason to make it final.

ro0NL and Koc reacted with thumbs up emoji
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍 for 3.3

@nicolas-grekas
Copy link
Member

(but missing composer.json update to make deps=low/high tests pass)

@nicolas-grekas
Copy link
Member

good for merge on my side

@stof
Copy link
Member

OK, deps=high failing is because this is not yet merged in 3.4

@stof
Copy link
Member

Thank you@ogizanagi.

@stofstof merged commit68c1917 intosymfony:3.3May 26, 2017
stof added a commit that referenced this pull requestMay 26, 2017
…o the component (ogizanagi)This PR was merged into the 3.3 branch.Discussion----------[FrameworkBundle][Validator] Move the PSR-11 factory to the component| Q             | A| ------------- | ---| Branch?       | 3.3 <!-- see comment below -->| Bug fix?      | no| New feature?  | no <!-- don't forget updating src/**/CHANGELOG.md files -->| BC breaks?    | no| Deprecations? | yes <!-- don't forget updating UPGRADE-*.md files -->| Tests pass?   | yes| Fixed tickets |#22887 (comment) <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | N/AInstead of the 3 following deprecations: * The `ConstraintValidatorFactory::$validators` and `$container` properties   have been deprecated and will be removed in 4.0. * Extending `ConstraintValidatorFactory` is deprecated and won't be supported in 4.0.* Passing an array of validators or validator aliases as the second argument of   `ConstraintValidatorFactory::__construct()` is deprecated since 3.3 and will   be removed in 4.0. Use the service locator instead.I'd suggest simply deprecating the FrameworkBundle's class in favor of using a new `ContainerConstraintValidatorFactory`. To me, there is no reason anyone using the validator component without the framework bundle cannot use this PSR-11 compliant implementation, nor I see a reason to make it final.Commits-------68c1917 [FrameworkBundle][Validator] Move the PSR-11 factory to the component
@ogizanagiogizanagi deleted the mv_container_cons_validator_factory branchMay 26, 2017 10:12
@fabpotfabpot mentioned this pull requestMay 29, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@stofstofstof approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

3.3

Development

Successfully merging this pull request may close these issues.

4 participants

@ogizanagi@nicolas-grekas@stof@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp