Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpFoundation] Add Request::HEADER_X_FORWARDED_AWS_ELB const#22904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:3.3fromnicolas-grekas:req-x
May 25, 2017

Conversation

@nicolas-grekas
Copy link
Member

QA
Branch?3.3
Bug fix?yes (a missing part of a 3.3 feat.)
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets-
LicenseMIT
Doc PR-

Seesymfony/symfony-docs#7045

@nicolas-grekas
Copy link
MemberAuthor

nicolas-grekas commentedMay 25, 2017•
edited
Loading

Can we ignore fabbot report here? Alignment is desired to me...

Copy link
Member

@xabbuhxabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

If we prefer to use the binary format, I am in favour of keep the alignment to ease readability.

@javiereguiluz
Copy link
Member

I don't think we should keep the alignment. If we apply some code formatting syntax, we should apply it always and without exceptions. Otherwise this will cause problems when running the php-cs-fixer in the entire codebase, which is done from time to time.

vehsamrak reacted with thumbs up emoji

@nicolas-grekas
Copy link
MemberAuthor

ok, fabbot green

@nicolas-grekasnicolas-grekas changed the title[HttpFoundation] Add Request::HEADER_X_FORWARDED_AWS const[HttpFoundation] Add Request::HEADER_X_FORWARDED_AWS_ELB constMay 25, 2017
@nicolas-grekas
Copy link
MemberAuthor

Just renamed the const to be even more explicit:Request::HEADER_X_FORWARDED_AWS_ELB

@weaverryan
Copy link
Member

👍 This will help the docs - it's already complex enough :)

@fabpot
Copy link
Member

Thank you@nicolas-grekas.

@fabpotfabpot merged commit9ba12b0 intosymfony:3.3May 25, 2017
fabpot added a commit that referenced this pull requestMay 25, 2017
…LB const (nicolas-grekas)This PR was merged into the 3.3 branch.Discussion----------[HttpFoundation] Add Request::HEADER_X_FORWARDED_AWS_ELB const| Q             | A| ------------- | ---| Branch?       | 3.3| Bug fix?      | yes (a missing part of a 3.3 feat.)| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -Seesymfony/symfony-docs#7045Commits-------9ba12b0 [HttpFoundation] Add Request::HEADER_X_FORWARDED_AWS_ELB const
@nicolas-grekasnicolas-grekas deleted the req-x branchMay 29, 2017 07:35
@fabpotfabpot mentioned this pull requestMay 29, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@xabbuhxabbuhxabbuh approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

3.3

Development

Successfully merging this pull request may close these issues.

6 participants

@nicolas-grekas@javiereguiluz@weaverryan@fabpot@xabbuh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp