Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Fix missing abstract key in XmlDumper#22901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
xabbuh left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍 (I don't like theservices<number> naming, but the change itself looks good)
8b39e95 toad81c6eCompareweaverryan commentedMay 25, 2017
@xabbuh yea, me either :). I've renamed it! |
Caused mis-reporting of abstract key (always no) in debug:container
ad81c6e to40f60ecComparefabpot commentedMay 25, 2017
Thank you@weaverryan. |
This PR was merged into the 2.7 branch.Discussion----------Fix missing abstract key in XmlDumper| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | none| License | MIT| Doc PR | n/aUnless I'm missing something, the abstract key was missing in the XmlDumper. I noticed it when using `debug:container some_abstract_service` and was seeing "no" for abstract.When this merges to 3.3, the `services-abstract.xml` will need to change to this:```xml<?xml version="1.0" encoding="utf-8"?><container xmlns="http://symfony.com/schema/dic/services" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://symfony.com/schema/dic/serviceshttp://symfony.com/schema/dic/services/services-1.0.xsd"> <services> <service synthetic="true"/> <service abstract="true"/> <service alias="service_container" public="false"/> <service alias="service_container" public="false"/> </services></container>```Commits-------40f60ec Fixing missing abstract attribute in XmlDumper
Uh oh!
There was an error while loading.Please reload this page.
Unless I'm missing something, the abstract key was missing in the XmlDumper. I noticed it when using
debug:container some_abstract_serviceand was seeing "no" for abstract.When this merges to 3.3, the
services-abstract.xmlwill need to change to this: