Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[ProxyManager] Add FC layer#22892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| * Autowiring services based on the types they implement is deprecated and won't be supported in version 4.0. Rename (or alias) your services to their FQCN id to make them autowirable. | ||
| *[BC BREAK] The`NullDumper` class has been made final |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this looks wrong to me. It is not actually final in 3.3
nicolas-grekasMay 24, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@final + the BC break means to me that we're considering the class final for real, taking advantage of it. IMHO, it sends the good info to the reader.
This PR was merged into the 3.3 branch.Discussion----------[ProxyManager] Add FC layer| Q | A| ------------- | ---| Branch? | 3.3| Bug fix? | no| New feature? | no| BC breaks? | yes - minor| Deprecations? | yes - made a class final| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -This makes PRoxyDumper compatible with DumperInterface v4.0.Technically, this is a BC break, but since I really don't expect anyone to extend ProxyDumper, I think we should do it - on 3.3 to close the gap as early as possible.Commits-------4aeb6d8 [ProxyManager] Add FC layer
This PR was merged into the 3.4 branch.Discussion----------[travis] Fix 3/4 cross tests| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | needs#22892| Fixed tickets | -| License | MIT| Doc PR | -I just realized that using 7.0 to run deps=high test prevents loading 4.0 versions of deps.Commits-------6311be7 [travis] Fix 3/4 cross tests
This makes PRoxyDumper compatible with DumperInterface v4.0.
Technically, this is a BC break, but since I really don't expect anyone to extend ProxyDumper, I think we should do it - on 3.3 to close the gap as early as possible.