Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Updated choice_widget to display the preferred_choice separator only if c#2289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…if choice|length >0 and separator is not blank.
craue commentedSep 28, 2011
How about |
whattheken commentedSep 28, 2011
That looks better. Thanks. |
fabpot commentedSep 28, 2011
Can you also add some unit tests? |
craue commentedSep 28, 2011
This change should also be made in the corresponding PHP template (as done in#1787). |
whattheken commentedSep 29, 2011
@fabpot Never used PHPUnit tests before but I can give it a shot. |
fabpot commentedSep 29, 2011
@Robotron2000 nevermind then, I will add some myself. |
whattheken commentedSep 29, 2011
@craue Good idea. Make same changes to the PHP template. |
fabpot commentedSep 29, 2011
done here:d429594 |
… in the kernel (aschempp)This PR was merged into the 3.3 branch.Discussion----------[FrameworkBundle] Only override getProjectDir if it exists in the kernel| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#22872,#2289| License | MIT| Doc PR | -As discussed with@nicolas-grekas, the `getProjectDir` method does not belong to `KernelInterface` so it can't just be called. I think we should also not add the method to the kernel if it does not exist in the parent, because we would not have a useful value to return.Commits-------c7ed08e Only override getProjectDir if it exists in the kernel
Updated choice_widget to display the preferred_choice separator only if choice|length >0 and separator is not blank.